Add the dataset of PR review comments #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarkovtsev
requested changes
Mar 22, 2019
|
Besides, @warenlg you should post here all the scripts/notebooks you used to generate this dataset. No need to polish them, they are just for the reference. |
warenlg
force-pushed
the
PR-review-comments
branch
from
9db6a6b to
0f605bb
Compare
marnovo
requested changes
Mar 22, 2019
There was a problem hiding this comment.
@warenlg agreed w/ Vadim's points.
Also please add the dataset to the root README.md index akin to the others we have so it's more obvious to users it exists.
Signed-off-by: Waren Long <waren@sourced.tech>
warenlg
force-pushed
the
PR-review-comments
branch
2 times, most recently
from
9a0cc9e to
ae16318
Compare
|
Done, I added 2 notebooks:
|
warenlg
force-pushed
the
PR-review-comments
branch
from
ae16318 to
244402b
Compare
vmarkovtsev
requested changes
Mar 25, 2019
Signed-off-by: Waren Long <waren@sourced.tech>
warenlg
force-pushed
the
PR-review-comments
branch
from
244402b to
3813272
Compare
vmarkovtsev
approved these changes
Mar 25, 2019
|
@marnovo Taking the liberty of merging this one. Waren has applied your suggestion with the top-level README mention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Waren Long waren@sourced.tech