-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
legal: Replace MIT by Apache2 license #77
legal: Replace MIT by Apache2 license #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 85.03% 85.03%
=======================================
Files 16 16
Lines 942 942
=======================================
Hits 801 801
Misses 83 83
Partials 58 58 Continue to review full report at Codecov.
|
LICENSE
Outdated
same "printed page" as the copyright notice for easier | ||
identification within third-party archives. | ||
|
||
Copyright {yyyy} {name of copyright owner} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall this be replaced with proper copyright?
As per https://github.com/src-d/guide/blob/master/engineering/documents/apache/LICENSE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I didn't know we had those files in the guide. We should certainly use them.
That being said, I don't think the LICENSE file is the place where that replacing should be done since:
- the description doesn't make sense if replaced.
- you're modifying a LICENSE file that should be generic.
That being said. if that's the way the LICENSE files are in our guide, I guess it's already been defined that we should use those, so I'll replace it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
Looks great to me |
No description provided.