Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legal: Replace MIT by Apache2 license #77

Merged
merged 1 commit into from
Jul 19, 2017
Merged

legal: Replace MIT by Apache2 license #77

merged 1 commit into from
Jul 19, 2017

Conversation

abeaumont
Copy link
Contributor

No description provided.

@abeaumont abeaumont self-assigned this Jul 14, 2017
@codecov
Copy link

codecov bot commented Jul 14, 2017

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files          16       16           
  Lines         942      942           
=======================================
  Hits          801      801           
  Misses         83       83           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608949f...3f3d1c0. Read the comment docs.

LICENSE Outdated
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright {yyyy} {name of copyright owner}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@abeaumont abeaumont Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I didn't know we had those files in the guide. We should certainly use them.
That being said, I don't think the LICENSE file is the place where that replacing should be done since:

  • the description doesn't make sense if replaced.
  • you're modifying a LICENSE file that should be generic.

That being said. if that's the way the LICENSE files are in our guide, I guess it's already been defined that we should use those, so I'll replace it anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@bzz
Copy link
Contributor

bzz commented Jul 17, 2017

Looks great to me

@abeaumont abeaumont merged commit 77db344 into src-d:master Jul 19, 2017
@abeaumont abeaumont deleted the feature/replace-mit-by-apache2-license branch July 19, 2017 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants