add C exports for enry #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
commented
Aug 7, 2017
| @@ -0,0 +1,140 @@ | |||
| // +build darwin,cgo linux,cgo | |||
| // +build amd64 | |||
There was a problem hiding this comment.
perhaps we should not restrict this here, but on the client?
There was a problem hiding this comment.
It doesn't seem a big deal, we can leave it here for now and be less restrictive or move to the client in the future if needed.
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 83.67% 83.67%
=======================================
Files 17 17
Lines 980 980
=======================================
Hits 820 820
Misses 98 98
Partials 62 62Continue to review full report at Codecov.
|
This was referenced Aug 8, 2017
Merged
abeaumont
approved these changes
Aug 8, 2017
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/shared-lib
branch
from
516e19e to
33ff3ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @mcuadros @smola @mcarmonaa @abeaumont