[HOTFIX] Set DB conn reuse timeout #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
approved these changes
Oct 5, 2018
There was a problem hiding this comment.
Adding @ajnavarro, since he or someone else at data retrieval should not better than me.
|
I think this will not solve the issue. The connection will expire one minute after it was first created, I guess causing the same error. |
|
So, if I understand your comment, gitbase expires connections after one minute from creation, not one minute of inactivity? |
|
@carlosms ,no that is what is doing |
|
I think the correct fix should test the connection before use it. See: https://golang.org/pkg/database/sql/#Conn.PingContext |
carlosms
force-pushed
the
idle-db-timeout
branch
from
9beca50 to
b4c1a96
Compare
|
Push forced a new commit to set max idle connections to 0. |
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
carlosms
force-pushed
the
idle-db-timeout
branch
from
b4c1a96 to
196338d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an idle time of >60s the next query was always failing with
Query Failed - invalid connection.Apparently the problem is that the connection was close on gitbase's end and we still kept it open on our side.
More context in this thread:
go-sql-driver/mysql#674 (comment)