Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for solaris - fix #69 #70

Merged
merged 1 commit into from
Jun 30, 2019
Merged

Add support for solaris - fix #69 #70

merged 1 commit into from
Jun 30, 2019

Conversation

kuba--
Copy link

@kuba-- kuba-- commented Mar 7, 2019

Signed-off-by: kuba-- kuba@sourced.tech
Fixes #69

Signed-off-by: kuba-- <kuba@sourced.tech>
@jfontan jfontan requested a review from mcuadros April 5, 2019 15:18
@fkorotkov
Copy link
Contributor

@mcuadros gentle ping. 😅Working on Solaris support for Cirrus CI and would love to see this merged since our agent uses go-git for cloning which depends on go-billy.

@mcuadros mcuadros merged commit 63e7cf0 into src-d:master Jun 30, 2019
@mcuadros
Copy link
Contributor

@fkorotkov
Copy link
Contributor

@mcuadros greatly appreciate it! 🙌

@fkorotkov
Copy link
Contributor

Hey @kuba--, does seem like this change fixed the issue of building for Solaris. Could you please take a look at #71 where I've also added tests for building binaries for supported platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building on Illumos Issue
4 participants