This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
*: windows support, some more fixes #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
reviewed
Aug 2, 2017
repository.go
Outdated
| @@ -286,7 +286,8 @@ func dotGitFileToOSFilesystem(path string, fs billy.Filesystem) (billy.Filesyste | |||
| return nil, fmt.Errorf(".git file has no %s prefix", prefix) | |||
| } | |||
|
|
|||
| gitdir := line[len(prefix):] | |||
| gitdir := strings.Split(line[len(prefix):], "\n")[0] | |||
| gitdir = strings.Trim(gitdir, "\r") | |||
There was a problem hiding this comment.
doesn't the following line's TrimSpace already remove the \r?
There was a problem hiding this comment.
Yes, certainly it already does. Thanks for point it!
…orySuite.TestPlainOpenBareRelativeGitDirFileTrailingGarbage"
…uite.TestCheckoutIndexOS"
…ePackSuite.TearDownTest"
…uite.TestCheckoutSymlink"
mcarmonaa
force-pushed
the
fix/windows-support
branch
from
53ec86e to
fadb6e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
==========================================
- Coverage 78.17% 77.52% -0.66%
==========================================
Files 129 129
Lines 9749 9747 -2
==========================================
- Hits 7621 7556 -65
- Misses 1302 1376 +74
+ Partials 826 815 -11
Continue to review full report at Codecov.
|
mcarmonaa
added a commit
to mcarmonaa/go-git
that referenced
this pull request
Aug 4, 2017
* fixed windows failed test: "134 FAIL: repository_test.go:340: RepositorySuite.TestPlainOpenBareRelativeGitDirFileTrailingGarbage" * fixed windows failed test: "143 FAIL: worktree_test.go:367: WorktreeSuite.TestCheckoutIndexOS" * fixed windows failed test: "296 FAIL: receive_pack_test.go:36: ReceivePackSuite.TearDownTest" * fixed windows failed test: "152 FAIL: worktree_test.go:278: WorktreeSuite.TestCheckoutSymlink"
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following bugs related to this log have been addressed: