Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gopkg.in/Masterminds/squirrel.v1 instead of github.com/Masterminds/squirrel #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faide
Copy link

@faide faide commented Jun 28, 2018

because the github version pulls from master and is not in synch with what kallax uses from squirrel.

See #279 for more reference

…s/squirrel

Signed-off-by: Florent AIDE <florent.aide@gmail.com>
@roobre
Copy link
Contributor

roobre commented Jul 1, 2018

Which go version are you using? According to squirrel's README:

NOTE: as of Go 1.6, go get correctly clones the Github default branch (which is v1 in this repo).
import "github.com/Masterminds/squirrel"

PR seems harmless and more explicit tho, so I'm inclined to merge it. Just want to know which is the root cause of the problem.

@faide
Copy link
Author

faide commented Jul 1, 2018 via email

@WnP
Copy link

WnP commented Feb 19, 2019

I'm using go version go1.11.1 linux/amd64 and have the same issue, this PR fix it.
Thanks @faide

@roobre roobre removed their assignment Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants