Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

TPC-H: Implement Inner Join #57

Closed
ajnavarro opened this issue Feb 27, 2018 · 0 comments
Closed

TPC-H: Implement Inner Join #57

ajnavarro opened this issue Feb 27, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ajnavarro
Copy link
Contributor

No description provided.

@ajnavarro ajnavarro added the enhancement New feature or request label Feb 27, 2018
@ajnavarro ajnavarro mentioned this issue Feb 27, 2018
14 tasks
@erizocosmico erizocosmico self-assigned this Feb 28, 2018
erizocosmico added a commit to erizocosmico/go-mysql-server that referenced this issue Feb 28, 2018
Closes src-d#57
Implements the INNER JOIN node, which right now is basically a Filter(cond, CrossJoin(left, right)) given it has no indexes whatsoever.
The only clause of the INNER JOIN implemented is the ON clause. USING does not make sense to implement until we have a proper handling of column qualifiers.
The implementation of INNER JOIN differs from the one in CROSS JOIN. While the cross join loads all the right rows in memory and iterates the left rows, the inner join creates a new iterator for each iteration of the left iterator, saving huge amounts of memory on large tables.

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico added a commit to erizocosmico/go-mysql-server that referenced this issue Feb 28, 2018
Closes src-d#57
Implements the INNER JOIN node, which right now is basically a Filter(cond, CrossJoin(left, right)) given it has no indexes whatsoever.
The only clause of the INNER JOIN implemented is the ON clause. USING does not make sense to implement until we have a proper handling of column qualifiers.
The implementation of INNER JOIN differs from the one in CROSS JOIN. While the cross join loads all the right rows in memory and iterates the left rows, the inner join creates a new iterator for each iteration of the left iterator, saving huge amounts of memory on large tables.

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico added a commit to erizocosmico/go-mysql-server that referenced this issue Feb 28, 2018
Closes src-d#57
Implements the INNER JOIN node, which right now is basically a Filter(cond, CrossJoin(left, right)) given it has no indexes whatsoever.
The only clause of the INNER JOIN implemented is the ON clause. USING does not make sense to implement until we have a proper handling of column qualifiers.
The implementation of INNER JOIN differs from the one in CROSS JOIN. While the cross join loads all the right rows in memory and iterates the left rows, the inner join creates a new iterator for each iteration of the left iterator, saving huge amounts of memory on large tables.

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico added a commit to erizocosmico/go-mysql-server that referenced this issue Feb 28, 2018
Closes src-d#57
Implements the INNER JOIN node, which right now is basically a Filter(cond, CrossJoin(left, right)) given it has no indexes whatsoever.
The only clause of the INNER JOIN implemented is the ON clause. USING does not make sense to implement until we have a proper handling of column qualifiers.
The implementation of INNER JOIN differs from the one in CROSS JOIN. While the cross join loads all the right rows in memory and iterates the left rows, the inner join creates a new iterator for each iteration of the left iterator, saving huge amounts of memory on large tables.

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico added a commit to erizocosmico/go-mysql-server that referenced this issue Feb 28, 2018
Closes src-d#57
Implements the INNER JOIN node, which right now is basically a Filter(cond, CrossJoin(left, right)) given it has no indexes whatsoever.
The only clause of the INNER JOIN implemented is the ON clause. USING does not make sense to implement until we have a proper handling of column qualifiers.
The implementation of INNER JOIN differs from the one in CROSS JOIN. While the cross join loads all the right rows in memory and iterates the left rows, the inner join creates a new iterator for each iteration of the left iterator, saving huge amounts of memory on large tables.

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants