Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Supported client examples do not use defaults for user, pass and database names #597

Closed
smola opened this issue Jan 18, 2019 · 0 comments
Closed

Supported client examples do not use defaults for user, pass and database names #597

smola opened this issue Jan 18, 2019 · 0 comments
Assignees
@kuba--
Labels
documentation This is a documentation issue or pull request enhancement New feature or request

Comments

@smola
Copy link
Collaborator

smola commented Jan 18, 2019 •
edited
Loading

https://github.com/src-d/go-mysql-server/blob/master/SUPPORTED_CLIENTS.md#pymysql

It seems detauls should be user root, empty pass and gitbase database, but that does not match the examples. It would be nice if examples worked with defaults out of the box.

Using pymysql here and gitbase v0.18.0.
@ajnavarro ajnavarro added enhancement New feature or request documentation This is a documentation issue or pull request labels Jan 28, 2019
@kuba-- kuba-- self-assigned this Jan 29, 2019
@kuba-- kuba-- mentioned this issue Jan 29, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuba-- kuba--

Labels
documentation This is a documentation issue or pull request enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smola @ajnavarro @kuba--