-
Notifications
You must be signed in to change notification settings - Fork 109
Conversation
Signed-off-by: kuba-- <kuba@sourced.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUPPORTED_CLIENTS.md
Outdated
cursorclass=pymysql.cursors.DictCursor) | ||
|
||
try: | ||
with connection.cursor() as cursor: | ||
sql = "SELECT foo FROM bar" | ||
sql = "SELECT * FROM commit_files LIMIT 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are go-mysql-server examples, not gitbase examples. I don't think we should mix the two of them
@smola - WDYT? Maybe docs should follow the schema from _example |
@src-d/data-processing, @smola |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass
Signed-off-by: kuba-- <kuba@sourced.tech>
Signed-off-by: kuba-- kuba@sourced.tech
Closes #597