This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sqle: change Engine constructor to accept a Config struct #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
reviewed
Jul 12, 2018
engine.go
Outdated
| // New creates a new Engine with custom configuration. To create an Engine with | ||
| // the default settings use `NewDefault`. | ||
| func New(c *sql.Catalog, a *analyzer.Analyzer, cfg *Config) *Engine { | ||
| var versionPostfix = "go-mysql-server" |
There was a problem hiding this comment.
shall we just do not register the "VERSION()" function if that config property is empty? Or maybe just return the MySQL version and that's it
There was a problem hiding this comment.
That way, NewDefault will always return just the MySQL version
erizocosmico
force-pushed
the
feature/engine-constructor
branch
from
8b341f0 to
591d496
Compare
|
Done @ajnavarro |
ajnavarro
approved these changes
Jul 16, 2018
jfontan
approved these changes
Jul 16, 2018
|
Fix broken test and LGTM. |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/engine-constructor
branch
from
591d496 to
2abbea9
Compare
|
Should be fixed now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #285