This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql/analyzer: add negate index #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erizocosmico
suggested changes
Jul 17, 2018
sql/analyzer/assign_indexes.go
Outdated
| case *expression.Not: | ||
| r, err := getNegatedIndexes(a, e) | ||
| if err != nil { | ||
| return result, err |
There was a problem hiding this comment.
why not return nil, err?
|
|
||
| return getIndexes(or, a) | ||
| default: | ||
| return nil, nil |
There was a problem hiding this comment.
note that you're returning nil map here and a nil error, that will cause a panic iterating in the previous function over the map (since error is nil)
There was a problem hiding this comment.
iterate over a nil map doesn't cause a panic https://play.golang.org/p/0xG3j4aeS9R
There was a problem hiding this comment.
Uh, you're right. Nvm then
sql/analyzer/assign_indexes.go
Outdated
| @@ -438,6 +532,7 @@ func getMultiColumnIndexForExpressions( | |||
| exprs []columnExpr, | |||
| used map[sql.Expression]struct{}, | |||
| ) (index sql.Index, lookup sql.IndexLookup, err error) { | |||
|
|
|||
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
mcarmonaa
force-pushed
the
improvement/add-negate-index
branch
from
c44a82a to
c869740
Compare
Signed-off-by: Manuel Carmona <manu.carmona90@gmail.com>
mcarmonaa
force-pushed
the
improvement/add-negate-index
branch
from
c869740 to
60ca3a5
Compare
|
I added a commit handling 'NOT IN' expressions |
jfontan
approved these changes
Jul 17, 2018
erizocosmico
approved these changes
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262
Note that multicolumn indexes aren't used for
NOTexpressions.