This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
integration: add grafana queries to go integration #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
approved these changes
Oct 18, 2018
erizocosmico
approved these changes
Oct 19, 2018
|
@jfontan can you add some tests using date ranges? we should support #467 (comment) |
|
Also, when this is done, we should add grafana as a supported client: https://github.com/src-d/go-mysql-server/blob/master/SUPPORTED_CLIENTS.md |
mcarmonaa
approved these changes
Oct 19, 2018
Also added some helper functions to the test to retrieve a slice of
string slices for easier checking.
Grafana makes another query that seems to be erroneous but does not
complain:
show table columns
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
jfontan
force-pushed
the
improvement/add-grafana-queries
branch
from
2453e0b
to
86b866c
Compare
|
Rebased, added a test with grafana datetime format and mentions grafana in supported clients document. |
ajnavarro
approved these changes
Oct 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some helper functions to the test to retrieve a slice of string slices for easier checking.
Grafana makes another query that seems to be erroneous but does not complain:
Fixes #467