This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql/parse: support more than 2 tables on cross join #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
reviewed
Feb 26, 2018
| @@ -193,12 +193,12 @@ func tableExprsToTable(te sqlparser.TableExprs) (sql.Node, error) { | |||
| return nodes[0], nil | |||
| } | |||
|
|
|||
| if len(nodes) == 2 { | |||
| return plan.NewCrossJoin(nodes[0], nodes[1]), nil | |||
| join := plan.NewCrossJoin(nodes[0], nodes[1]) | |||
There was a problem hiding this comment.
should we check the len of nodes before?
There was a problem hiding this comment.
ajnavarro
approved these changes
Feb 26, 2018
jfontan
approved these changes
Feb 26, 2018
mcarmonaa
approved these changes
Feb 26, 2018
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/join-more-tables
branch
from
0192c81 to
36ef1b3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #38
Also, this is not inner join as said in the issue, is cross join, because INNER JOIN is not implemented right now.