This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Add support for set DEFAULT #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
reviewed
Oct 23, 2018
sql/expression/default.go
Outdated
|
|
||
| // Eval implements the Expression interface. | ||
| func (*DefaultColumn) Eval(ctx *sql.Context, r sql.Row) (interface{}, error) { | ||
| panic("unresolved column is a placeholder node, but Eval was called") |
There was a problem hiding this comment.
copied error from UnresolvedColumn.
There was a problem hiding this comment.
Fixed typos + added more verbose comments
erizocosmico
approved these changes
Oct 23, 2018
Signed-off-by: kuba-- <kuba@sourced.tech>
ajnavarro
approved these changes
Oct 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- kuba@sourced.tech