This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
analyzer: fix pushdown of filters with repeated table names #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
reviewed
Oct 24, 2018
sql/analyzer/filters.go
Outdated
| @@ -18,11 +18,15 @@ func (f filters) merge(f2 filters) { | |||
| func exprToTableFilters(expr sql.Expression) filters { | |||
| filtersByTable := make(filters) | |||
| for _, expr := range splitExpression(expr) { | |||
| var seenTables = make(map[string]struct{}) | |||
| var tables []string | |||
There was a problem hiding this comment.
do we need var tables []string now? If we just check:
if len(tables) == 1 {
filtersByTable[tables[0]] = append(filtersByTable[tables[0]], expr) filtersByTable[tables[0]] = append(filtersByTable[tables[0]], expr)
}
?
There was a problem hiding this comment.
How do you get the key from the map, then? You would need to range the map and that feels like this with extra steps
There was a problem hiding this comment.
that's true - we'll need to range and break, but on the other hand if we really need just 0th element then we may just memorise just one string instead of all slice and only set it if len(seen) == 0
kuba--
approved these changes
Oct 24, 2018
jfontan
approved these changes
Oct 24, 2018
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
fix/pushdown-filters
branch
from
b485e8f to
fd90e6d
Compare
|
Can we merge this before I update gitbase, so it also gets this fix? @ajnavarro |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes src-d/gitbase#579