Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Feature/lpad rpad #522

Merged
merged 4 commits into from
Nov 5, 2018
Merged

Feature/lpad rpad #522

merged 4 commits into from
Nov 5, 2018

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented Nov 1, 2018

No description provided.

Signed-off-by: Theo Despoudis <thdespou@hotmail.com>
Signed-off-by: Theo Despoudis <thdespou@hotmail.com>
@theodesp theodesp mentioned this pull request Nov 1, 2018
@erizocosmico erizocosmico requested a review from a team November 2, 2018 09:01
Copy link
Contributor

@mcarmonaa mcarmonaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor requested changes LGTM, thanks for your contribution!

sql/expression/function/rpad_lpad.go Outdated Show resolved Hide resolved
sql/expression/function/rpad_lpad.go Outdated Show resolved Hide resolved
sql/expression/function/rpad_lpad.go Outdated Show resolved Hide resolved
sql/expression/function/rpad_lpad.go Show resolved Hide resolved
sql/expression/function/rpad_lpad.go Outdated Show resolved Hide resolved
sql/expression/function/rpad_lpad.go Outdated Show resolved Hide resolved
sql/expression/function/rpad_lpad.go Outdated Show resolved Hide resolved
sql/expression/function/logarithm.go Outdated Show resolved Hide resolved
Signed-off-by: Theo Despoudis <thdespou@hotmail.com>
@theodesp
Copy link
Contributor Author

theodesp commented Nov 2, 2018

PR updated

Signed-off-by: Theo Despoudis <thdespou@hotmail.com>
@ajnavarro ajnavarro merged commit 6775578 into src-d:master Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants