Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Add error for subqueries #552

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Add error for subqueries #552

merged 1 commit into from
Nov 20, 2018

Conversation

kuba--
Copy link
Contributor

@kuba-- kuba-- commented Nov 19, 2018

Signed-off-by: kuba-- kuba@sourced.tech
Closes src-d/gitbase#622

So far we don't support subqueries (for filters/conditions). This PR adds explicit error message for subqueries.

Signed-off-by: kuba-- <kuba@sourced.tech>
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test checking the error please?

@kuba--
Copy link
Contributor Author

kuba-- commented Nov 19, 2018

I've added to parse_test

@ajnavarro ajnavarro merged commit 2ee52e3 into src-d:master Nov 20, 2018
@kuba-- kuba-- deleted the fix-622/subquery branch November 20, 2018 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants