Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

sql/plan: speed up InnerJoin iterator #578

Merged
merged 1 commit into from
Jan 14, 2019
Merged

sql/plan: speed up InnerJoin iterator #578

merged 1 commit into from
Jan 14, 2019

Conversation

erizocosmico
Copy link
Contributor 

pkg: gopkg.in/src-d/go-mysql-server.v0/sql/plan
BenchmarkInnerJoin/inner_join-4         	   50000	     34188 ns/op	   11415 B/op	     169 allocs/op
BenchmarkInnerJoin/cross_join_with_filter-4         	   30000	     41608 ns/op	   12119 B/op	     181 allocs/op
PASS
ok  	gopkg.in/src-d/go-mysql-server.v0/sql/plan	3.795s

@erizocosmico erizocosmico added the performance Performance improvements label Dec 21, 2018
@erizocosmico erizocosmico self-assigned this Dec 21, 2018
@erizocosmico erizocosmico requested a review from a team December 21, 2018 14:20
kuba--
kuba-- reviewed Dec 21, 2018
View reviewed changes
sql/plan/innerjoin.go Outdated Show resolved Hide resolved
@ajnavarro
Copy link
Contributor

@erizocosmico LGTM, but could you have a look at @kuba-- and @jfontan comments? thanks!

@erizocosmico
Copy link
Contributor Author

Sure @ajnavarro

@erizocosmico
sql/plan: speed up InnerJoin iterator
ca55244 
pkg: gopkg.in/src-d/go-mysql-server.v0/sql/plan
BenchmarkInnerJoin/inner_join-4         	   50000	     34188 ns/op	   11415 B/op	     169 allocs/op
BenchmarkInnerJoin/cross_join_with_filter-4         	   30000	     41608 ns/op	   12119 B/op	     181 allocs/op
PASS
ok  	gopkg.in/src-d/go-mysql-server.v0/sql/plan	3.795s

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
Copy link
Contributor Author

Done

@ajnavarro ajnavarro merged commit 1bdf44b into src-d:master Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kuba-- kuba-- kuba-- approved these changes

@jfontan jfontan jfontan approved these changes

Assignees

@erizocosmico erizocosmico

Labels
performance Performance improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erizocosmico @ajnavarro @jfontan @kuba--