This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
Added MySQL SLEEP function #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
reviewed
Apr 2, 2019
sql/expression/function/sleep.go
Outdated
| } | ||
|
|
||
| if child.(int32) > 0 { | ||
| time.Sleep(time.Duration(child.(int32)) * time.Second) |
There was a problem hiding this comment.
Based on mysql docs a fraction can be used, so my understanding is that someone can write sleep(0.5) to sleep for 500 ms. So, I think it's better to make it a float function.
There was a problem hiding this comment.
True! I'll fix it in the next push.
There was a problem hiding this comment.
Fixed and pushed, PTAL when you can.
or rebuild: |
erizocosmico
approved these changes
Apr 3, 2019
|
@juanjux why is there a "foo" commit in the history? Leftover? :P |
|
@erizocosmico 🤦♂️ yes, I call foo the commits I do with the intention of rebasing so I don't forget to do it. Clearly it didn't work this time. |
|
@ajnavarro done! |
added 2 commits
April 11, 2019 11:02
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
PR rebased to the new ` |
|
@juanjux Check PR content, should we remove base64 Functions from this PR? |
added 2 commits
April 11, 2019 11:17
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Add also test in engine_test.go Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech> Remove base64 stuff Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
|
@ajnavarro done. |
ajnavarro
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MySQL SLEEP function, that seems to be useful for some kinds of testing.
Fixes #647.
Signed-off-by: Juanjo Alvarez juanjo@sourced.tech