This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Some vet tools fixes #688
Merged
Some vet tools fixes #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
approved these changes
Apr 23, 2019
mcuadros
reviewed
Apr 23, 2019
auth/common_test.go
Outdated
| db, err := dsql.Open("mysql", connString(c.user, "")) | ||
| req.NoError(err) | ||
| _, err = db.Query(c.query) | ||
| db, e := dsql.Open("mysql", connString(c.user, "")) |
Contributor
Author
There was a problem hiding this comment.
To shut up go vet about shadowing err in the enclosing context.
Contributor
There was a problem hiding this comment.
Then you can do
var db *sql.DB
db, err = dsql.Open(yada yada)
Contributor
Author
There was a problem hiding this comment.
var db *dsql.DB actually. It's one line more, but ok, err is certainly more easy to human-parse than just e.
erizocosmico
approved these changes
Apr 24, 2019
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Contributor
Author
|
@ajnavarro check the last commit (I'll rebase it later), I've renamed most of the |
ajnavarro
approved these changes
Apr 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686 except for a false positive (bug?) in the nilness tool.