Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

sql/analyzer: wrap all time and date expressions with convert #699

Merged
merged 3 commits into from
May 6, 2019
Merged

sql/analyzer: wrap all time and date expressions with convert #699

merged 3 commits into from
May 6, 2019

Conversation

erizocosmico
Copy link
Contributor

Fixes #698

@erizocosmico
sql: validate dates in expressions
4c7bc78 
Add validation to all functions and expressions that deal with
dates and datetimes.

Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
sql/analyzer: wrap all time and date expressions with convert
874fb42 
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico erizocosmico requested a review from a team April 30, 2019 15:29
@erizocosmico
sql/expression: convert to Datetime should be of timestamp type
baba1f1 
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
@erizocosmico
Copy link
Contributor Author

Fixed the tests. CONVERT(x, DATETIME) was returning Date as its type instead of Timestamp, for some reason 🤷‍♂

@ajnavarro ajnavarro merged commit bb8122d into src-d:master May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@juanjux juanjux juanjux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure dates and times are within the supported range
3 participants
@erizocosmico @juanjux @ajnavarro