This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql/analyzer: run convert_dates rule after prune_columns #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
|
I wonder the debug process you followed to discover that, anyway you're a coding monster. |
juanjux
approved these changes
May 7, 2019
|
@juanjux went down the rabbit hole adding more logic to the squash rule until I saw prune_columns was not working as expected because of things convert_dates was doing. Executing it later made all problems go away. Actually, the only requirement convert_dates has is to execute before pushdown and after everything has been resolved. So I moved it just before pushdown. |
ajnavarro
approved these changes
May 7, 2019
|
Shall we merge this @ajnavarro? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a while debugging on gitbase I realised only this fix would also fix all the problems it had with squash rule with much less code.
Analyzer bugs are weird 🤷♂