This repository has been archived by the owner on Jan 28, 2021. It is now read-only.
sql: implement count distinct #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jul 5, 2019
erizocosmico
force-pushed
the
feature/count-distinct
branch
2 times, most recently
from
23da2e9
to
166881a
Compare
|
LGTM after the tests pass (TestParseErrors/SELECT_COUNT(DISTINCT_foo)_FROM_b (0.00s)) |
|
It's passing now. (CI is not because openjdk10 stuff |
Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
erizocosmico
force-pushed
the
feature/count-distinct
branch
from
166881a
to
3e40534
Compare
kuba--
approved these changes
Jul 5, 2019
juanjux
approved these changes
Jul 5, 2019
ajnavarro
approved these changes
Jul 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.