Fix GetChanges issue with changes in both sides #600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #486
depends on src-d/go-git#1097
depends on src-d/go-git-fixtures#13supersedes #530
This PR fix #486, so when an analyzer reviews the PR of
get-changes-from-outdated-pr-candidate
againstget-changes-from-outdated-pr
, it should not fail (as it's currently happening here)breaking changes
DataService.GetChanges
is currently returning the differences betweenbase
andhead
, so when this is merged, it will return the differences betweengit merge-base base head
andhead
.In case any analyzer wants to get the changes between
base
andhead
it should configure theChangeRequest.TwoDotsMode
, astrue
as described by src-d/lookout-sdk#76