Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetChanges issue with changes in both sides #600

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Mar 25, 2019

fix #486

depends on src-d/go-git#1097
depends on src-d/go-git-fixtures#13
supersedes #530

This PR fix #486, so when an analyzer reviews the PR of get-changes-from-outdated-pr-candidate against get-changes-from-outdated-pr, it should not fail (as it's currently happening here)

* 3c9686a (get-changes-from-outdated-pr) Deletes something in 'golang.go' file
|
| * 5de771f (get-changes-from-outdated-pr-candidate) Creates a new 'javascript.js' file
| |
| /   
* 44034c9 (common-ancestor) creates a new 'golang.go' file

breaking changes

DataService.GetChanges is currently returning the differences between base and head, so when this is merged, it will return the differences between git merge-base base head and head.

In case any analyzer wants to get the changes between base and head it should configure the ChangeRequest.TwoDotsMode, as true as described by src-d/lookout-sdk#76

…idate

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo self-assigned this Mar 25, 2019
@dpordomingo dpordomingo added the bug Something isn't working label Mar 25, 2019
@dpordomingo
Copy link
Contributor Author

Travis is failing at Generated code stage https://travis-ci.com/src-d/lookout/jobs/187599618 because vendor is currently hardcoded at 9a4e7e2 (because it has not been yet merged on go-git nor go-git-fixtures)

@carlosms carlosms added the blocked Can not be started or continued for external limitations label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can not be started or continued for external limitations bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetChanges is returning files that didn't change in the PR
2 participants