Overhaul repo config handling #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
versecafe
commented
Sep 3, 2024
•
versecafe
commented
- Centralized config package
- New TS Configs
- CLI into TS on new configs
benjreinhart
approved these changes
Sep 3, 2024
srcbook/package.json
Outdated
| @@ -5,17 +5,19 @@ | |||
| "type": "module", | |||
| "bin": "./bin/cli.mjs", | |||
There was a problem hiding this comment.
I think this is what is needed for the binary in production, not the start command below. This will need the proper path.
There was a problem hiding this comment.
@benjreinhart yep totally missed that, fixed it and tested with npm link srcbook start works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.