added optional parameter to use sandbox urls #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting out, testing or developing with this library it is useful not directly send all of the request to the regular API but instead to the dedicated ORCID sandbox. This change adds an optional parameter that would actively cause the endpoint URL be switched from the regular API to the sandbox. Since the default is set to False, this change is backward compatible with existing implementations that use this library.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sri0606
approved these changes
May 9, 2024
DavidFichtmueller
added a commit
to DavidFichtmueller/PyOrcid
that referenced
this pull request
May 14, 2024
Merge pull request sri0606#5 from DavidFichtmueller/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting out, testing or developing with this library it is useful not directly send all of the request to the regular API but instead to the dedicated ORCID sandbox. This change adds an optional parameter that would actively cause the endpoint URL be switched from the regular API to the sandbox. Since the default is set to False, this change is backward compatible with existing implementations that use this library.