Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folgezettel-aware sidebar + new configurable 'default' layout #483

Merged
merged 36 commits into from
Dec 27, 2023

Conversation

srid
Copy link
Owner

@srid srid commented Dec 21, 2023

Resolves #473 by making the sidebar tree be built based on not only the folder structure but also folgezettel relationships.

Also replaces both 'book' and 'note' layout with a single 'default' layout in which all of sidebar, uptree and breadcrumbs can be toggled on or of.

Still exploring this feature ...

  • Create a working version for nixos.asia
  • [ ] A notion of 'primary' parent?
  • Change semantics of folder-folgezettel (reverse). Done ... does it make sense?
  • "Index" (-/all) should always include all notes, even if they cannot be reached from top (due to folder-folgezettel being cut off at some point or due to disconnected graphs). Perhaps this can be implemented by having index folder folgezettel automatically include orphans somehow (if so, under what user config?) https://en.wikipedia.org/wiki/Spanning_tree
    • Fix excessive use of bold in Index
    • Avoid having to specify folder-folgezettel to false in index note (for that private notebook deployed to CF pages)
  • use a different svg icon than 'folder'?
  • Replace 'book' and 'note' layout with a single layout
  • Performance (memoize tree)
  • Refactor

@srid
Copy link
Owner Author

srid commented Dec 21, 2023

First pass, showing multiple parents. Obviously the sidebar needs to be trimmed:

image

srid added a commit to nixos-asia/website that referenced this pull request Dec 21, 2023
@srid
Copy link
Owner Author

srid commented Dec 21, 2023

Using this in https://nixos.asia/en now as of nixos-asia/website@90db854. en.md specifies the top-level folgezettel relationship explicitly, so now our sidebar looks:

image

@srid
Copy link
Owner Author

srid commented Dec 21, 2023

It is a bit jarring to see flake-parts appear (unnecessarily) in two sub-trees here: https://nixos.asia/en/treefmt

image

@srid srid changed the title Folgezettel-aware sidebar Folgezettel-aware sidebar + new configurable 'default' layout Dec 26, 2023
@srid srid force-pushed the folgezettel-sidebar branch from ae3dc87 to d5470c3 Compare December 27, 2023 00:56
@srid srid marked this pull request as ready for review December 27, 2023 17:58
@srid srid merged commit 5807f69 into master Dec 27, 2023
@srid srid deleted the folgezettel-sidebar branch December 27, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folgezettel sidebar
1 participant