generated from srid/ema-template
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folgezettel-aware sidebar + new configurable 'default' layout #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srid
added a commit
to nixos-asia/website
that referenced
this pull request
Dec 21, 2023
This uses the draft PR: srid/emanote#483
Using this in https://nixos.asia/en now as of nixos-asia/website@90db854. |
It is a bit jarring to see |
Thus begin using a flag mechanism for templates
srid
changed the title
Folgezettel-aware sidebar
Folgezettel-aware sidebar + new configurable 'default' layout
Dec 26, 2023
srid
force-pushed
the
folgezettel-sidebar
branch
from
December 27, 2023 00:56
ae3dc87
to
d5470c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #473 by making the sidebar tree be built based on not only the folder structure but also folgezettel relationships.
Also replaces both 'book' and 'note' layout with a single 'default' layout in which all of sidebar, uptree and breadcrumbs can be toggled on or of.
Still exploring this feature ...
[ ] A notion of 'primary' parent?routeBreadcrumbs
); what to use? (Answer: fine as it is for now)[ ] Do we trim excessive parents? https://mathworld.wolfram.com/MaximumSpanningTree.html