-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add granular settings defaults (defaults.settings.{local, defined, all}
)
#275
Conversation
…ttings.default fmt
default-{current, defined, all}
settings defaults; rm defaults.settings.default
default-{current, defined, all}
settings defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Quick review.
- A separate
./test/*/flake.nix
would be good for testing defaults. - Rebase new
master
(docs: How to work with local packages #276), and add documentation indocs/defaults.md
- Let's elaborate the examples in the Markdown docs, and have the option
description
link to them.
- Let's elaborate the examples in the Markdown docs, and have the option
- Not sure about the
defaults.settings.default-foo
naming; let me think about it.
cf. #301 |
…in `haskellProjectTests` settings
added tests: 1858124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My CI is down, but running nixci build
locally fails:
$ nixci build https://github.com/srid/haskell-flake/pull/275
[..]
$ nix log /nix/store/n1qm2m8qmg3d7q25swl3h8cqxhsng9na-haskell-flake-test-0.1.0.0.drv | tail -6
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/n1qm2m8qmg3d7q25swl3h8cqxhsng9na-haskell-flake-test-0.1.0.0.drv^*'
Configuring haskell-flake-test-0.1.0.0...
CallStack (from HasCallStack):
withMetadata, called at libraries/Cabal/Cabal/src/Distribution/Simple/Utils.hs:368:14 in Cabal-3.10.1.0:Distribution.Simple.Utils
Error: Setup: Encountered missing or private dependencies:
hello
hello is not a library package random
I fixed and tested on Linux.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just not sure what emptyPackageSettings
is for exactly. When I replace it with {}
, the test still passes.
default-{current, defined, all}
settings defaultsdefaults.settings.{local, defined, all}
)
resolves #261
defaults.settings.default-{current, defined, all}
replacesdefaults.settings.default
TODO: