Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-package projects #34

Merged
merged 19 commits into from
Nov 9, 2022
Merged

Multi-package projects #34

merged 19 commits into from
Nov 9, 2022

Conversation

HariAmoor-professional
Copy link
Contributor

@HariAmoor-professional HariAmoor-professional commented Oct 30, 2022 •
edited
Loading

Resolves #7 and resolves #2

Not ready to be merged due to infinite recursion error Fixed

roberth
roberth reviewed Oct 30, 2022
View reviewed changes
flake-module.nix Outdated Show resolved Hide resolved
@srid srid mentioned this pull request Oct 30, 2022
Merged
1 task
@HariAmoor-professional HariAmoor-professional marked this pull request as ready for review November 1, 2022 00:00
@srid srid mentioned this pull request Nov 1, 2022
Merged
srid
srid reviewed Nov 1, 2022
View reviewed changes
Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise, this looks great.

@roberth What do you think about the flake attribute naming? Uses "$project-$package" (unless the project is named "default").

flake-module.nix Outdated Show resolved Hide resolved
roberth
roberth reviewed Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally ok, but I find it a bit hard to get the big picture because no docs were modified/added (except for the options reference docs of course).

flake-module.nix Outdated Show resolved Hide resolved
flake-module.nix Show resolved Hide resolved
@roberth
Copy link
Collaborator

roberth commented Nov 1, 2022

@roberth What do you think about the flake attribute naming? Uses "$project-$package" (unless the project is named "default").

lgtm

roberth
roberth reviewed Nov 1, 2022
View reviewed changes
flake-module.nix Outdated Show resolved Hide resolved
@srid
Copy link
Owner

srid commented Nov 1, 2022

I'll improve the README.md for this PR shortly.

@HariAmoor-professional HariAmoor-professional mentioned this pull request Nov 1, 2022
Closed
HariAmoor-professional and others added 4 commits November 1, 2022 13:06
@HariAmoor-professional @roberth
Update flake-module.nix
9ecb1cd 
Fix description for `options.packages.modifier`

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@srid
Rename for consistency
7113416
@srid
update README for the PR
c494e98
@srid @HariAmoor-professional
Remove unused top-level modifier option
db02a0c
@HariAmoor-professional HariAmoor-professional requested review from srid and roberth and removed request for srid November 7, 2022 21:46
@HariAmoor-professional HariAmoor-professional requested review from srid and roberth and removed request for roberth and srid November 7, 2022 21:46
@srid srid merged commit d17e16e into srid:master Nov 9, 2022
@srid srid mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid approved these changes

@roberth roberth Awaiting requested review from roberth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-package projects Do not create app if there is none
3 participants
@HariAmoor-professional @roberth @srid