Skip to content

refactor: fix dangerous default argument #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: fix dangerous default argument #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be15003
refactor: fix dangerous default argument
deepsource-dev-autofix[bot] Nov 22, 2023
2432463
style: format code with Autopep8, Black, ISort, Ruff Formatter and Yapf
deepsource-dev-autofix[bot] Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions demo_code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import random
import pdb
import sys as sys
import abc
import os
import pdb
import random
import subprocess
import abc
import sys as sys

# from django.db.models.expressions import RawSQL

Expand All @@ -27,16 +27,6 @@ def smethod():
def cmethod(cls, something):
"""class method-to-be"""











cmethod = classmethod(cmethod)


Expand All @@ -46,13 +36,17 @@ class RandomNumberGenerator:
def limits(self):
return self.limits

def get_number(self, min_max=[1, 10]):
def get_number(self, min_max=None):
"""Get a random number between min and max."""
if min_max is None:
min_max = [1, 10]
assert all([isinstance(i, int) for i in min_max])
return random.randint(*min_max)


def main(options: dict = {}) -> str:
def main(options: dict = None) -> str:
if options is None:
options = {}
pdb.set_trace()
if "run" in options:
value = options["run"]
Expand All @@ -71,7 +65,9 @@ def main(options: dict = {}) -> str:
f.close()


def moon_chooser(moon, moons=["europa", "callisto", "phobos"]):
def moon_chooser(moon, moons=None):
if moons is None:
moons = ["europa", "callisto", "phobos"]
if moon is not None:
moons.append(moon)

Expand Down