Zip file cannot be unzipped on Windows if the password contains a section sign

[barix]

Hello,

when I create a zip file with a password that contains a section character (§), I cannot unzip that file with the same password when using 7-Zip 19.00 (x64) on Windows. When I use the command line 7z x out.zip (p7zip Version 15.14.1) in cygwin or WinRar I was able to extract all files. I reverted the commit b69843a and was able to create and unzip a zip file with a password that contains a section character.

I think the crucial code section is Zip4jUtil#convertCharArrayToByteArray(char[]). Code after reverting b69843a (was the only merge conflict):

public class Zip4jUtil {
...
  public static byte[] convertCharArrayToByteArray(char[] charArray) {
    byte[] bytes = new byte[charArray.length];
    for (int i = 0; i < charArray.length; i++) {
      bytes[i] = (byte) charArray[i];
    }
    return bytes;
  }
...

convertCharArrayToByteArray("§".toCharArray()) without InternalZipConstants returns "�" and with InternalZipConstants "§".

[srikanth-lingala]

Using non-ascii characters for passwords is in a grey zone as far as zip specification is concerned. Some tools convert passwords to utf8 and some don't. With the change that you linked, zip4j converts the password to utf8 by default, and I guess Windows doesn't, and that's why it works fine in your case when you revert the utf8 conversion.

I added an option to ZipFile api to use utf8 or not for password encoding and decoding. If you are sure that your zip file will only be used on windows, you can now generated the zip files by not using utf8. You can set this flag via ZipFile.setUseUtf8CharsetForPasswords(boolean).

I will include this in the next release

[srikanth-lingala]

Fixed in v2.11.0 released today

[jiangxincode]

test_hun 焰.zip

This zip file is encrypted by "hun 焰", But it can not be decrypted by zip4j like this:

    public static void main(String[] args) {
        byte[] readBuffer = new byte[4096];
        Zip4jConfig zip4jConfig = new Zip4jConfig(StandardCharsets.UTF_8, 4096, false);
        try (ZipInputStream zipInputStream = new ZipInputStream(new FileInputStream("E:\\Code\\temp\\tmp\\test\\test_hun 焰.zip"), "hun 焰".toCharArray(), zip4jConfig)) {
            while (zipInputStream.getNextEntry() != null) {
                while (zipInputStream.read(readBuffer) != -1) {
                }
            }
            System.out.println("success");
        } catch (ZipException e) {
            System.out.println("fail1");
        } catch (IOException e) {
            System.out.println("fail2");
        }