fix: rename FailedNoneRetryable -> FailedNotRetryable (open-telemetry…

…#247) * fix: rename FailedNoneRetryable -> FailedNotRetryable * fix: build
srikanthccv · Sep 11, 2019 · 93c8b41 · 93c8b41
1 parent 8279133
commit 93c8b41
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/packages/opentelemetry-basic-tracer/src/export/ExportResult.ts b/packages/opentelemetry-basic-tracer/src/export/ExportResult.ts
@@ -16,6 +16,6 @@
 
 export enum ExportResult {
   Success,
-  FailedNonRetryable,
+  FailedNotRetryable,
   FailedRetryable,
 }
diff --git a/packages/opentelemetry-basic-tracer/src/export/InMemorySpanExporter.ts b/packages/opentelemetry-basic-tracer/src/export/InMemorySpanExporter.ts
@@ -31,7 +31,7 @@ export class InMemorySpanExporter implements SpanExporter {
     spans: ReadableSpan[],
     resultCallback: (result: ExportResult) => void
   ): void {
-    if (this._stopped) return resultCallback(ExportResult.FailedNonRetryable);
+    if (this._stopped) return resultCallback(ExportResult.FailedNotRetryable);
     this._finishedSpans.push(...spans);
     return resultCallback(ExportResult.Success);
   }

diff --git a/packages/opentelemetry-basic-tracer/test/export/InMemorySpanExporter.test.ts b/packages/opentelemetry-basic-tracer/test/export/InMemorySpanExporter.test.ts
@@ -78,13 +78,13 @@ describe('InMemorySpanExporter', () => {
     });
   });
 
-  it('should return the FailedNonRetryable result after shutdown', () => {
+  it('should return the FailedNotRetryable result after shutdown', () => {
     const exorter = new InMemorySpanExporter();
     exorter.shutdown();
 
     // after shutdown export should fail
     exorter.export([], (result: ExportResult) => {
-      assert.strictEqual(result, ExportResult.FailedNonRetryable);
+      assert.strictEqual(result, ExportResult.FailedNotRetryable);
     });
   });
 });
diff --git a/packages/opentelemetry-exporter-jaeger/src/jaeger.ts b/packages/opentelemetry-exporter-jaeger/src/jaeger.ts
@@ -69,7 +69,7 @@ export class JaegerExporter implements SpanExporter {
         if (err) {
           // @todo: decide whether to break out the loop on first error.
           this._logger.error(`failed to append span: ${err}`);
-          if (done) return done(ExportResult.FailedNonRetryable);
+          if (done) return done(ExportResult.FailedNotRetryable);
         }
       });
     }