Skip to content

Commit

Permalink
Separate proto gen
Browse files Browse the repository at this point in the history
  • Loading branch information
srikanthccv committed Nov 18, 2023
1 parent 89c30fd commit 988b1be
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 0 additions & 6 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,6 @@ sphinx-autodoc-typehints~=1.25
pytest==7.1.3
pytest-cov~=4.1
readme-renderer~=24.0
# This version of grpcio-tools ships with protoc 3.19.4 which appears to be compatible with
# both protobuf 3.19.x and 4.x (see https://github.com/protocolbuffers/protobuf/issues/11123).
# Bump this version with caution to preserve compatibility with protobuf 3.
# https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-proto/pyproject.toml#L28
grpcio-tools==1.48.1
mypy-protobuf~=3.0.0
# temporary fix. we should update the jinja, flask deps
# See https://github.com/pallets/markupsafe/issues/282
# breaking change introduced in markupsafe causes jinja, flask to break
Expand Down
6 changes: 6 additions & 0 deletions gen-requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# This version of grpcio-tools ships with protoc 3.19.4 which appears to be compatible with
# both protobuf 3.19.x and 4.x (see https://github.com/protocolbuffers/protobuf/issues/11123).
# Bump this version with caution to preserve compatibility with protobuf 3.
# https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-proto/pyproject.toml#L28
grpcio-tools==1.48.1
mypy-protobuf~=3.0.0
2 changes: 1 addition & 1 deletion scripts/proto_codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ echo "Creating temporary virtualenv at $venv_dir using $(python3 --version)"
python3 -m venv $venv_dir
source $venv_dir/bin/activate
python -m pip install \
-c $repo_root/dev-requirements.txt \
-c $repo_root/gen-requirements.txt \
grpcio-tools mypy-protobuf
echo 'python -m grpc_tools.protoc --version'
python -m grpc_tools.protoc --version
Expand Down

0 comments on commit 988b1be

Please sign in to comment.