Skip to content

Commit

Permalink
fix: minor fix (open-telemetry#153)
Browse files Browse the repository at this point in the history
* fix: minor fix

* fix: remove _ prefix from params
  • Loading branch information
mayurkale22 authored Aug 5, 2019
1 parent 9e46dfd commit b1dc1a3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/opentelemetry-core/src/trace/TracerDelegate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class TracerDelegate implements types.Tracer {
);
}

startSpan(name: string, options?: types.SpanOptions | undefined): types.Span {
startSpan(name: string, options?: types.SpanOptions): types.Span {
return this._currentTracer.startSpan.apply(
this._currentTracer,
// tslint:disable-next-line:no-any
Expand Down
4 changes: 2 additions & 2 deletions packages/opentelemetry-core/test/trace/TracerDelegate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('TracerDelegate', () => {
traceOptions: TraceOptions.UNSAMPLED,
};

describe('#constructor(...)', () => {
describe('constructor', () => {
it('should not crash with default constructor', () => {
functions.forEach(fn => {
const tracer = new TracerDelegate();
Expand Down Expand Up @@ -66,7 +66,7 @@ describe('TracerDelegate', () => {
assert.deepStrictEqual(dummyTracer.spyCounter, 1);
});

describe('#start/stop()', () => {
describe('.start/stop()', () => {
it('should use the fallback tracer when stop is called', () => {
const dummyTracerUser = new DummyTracer();
const dummyTracerFallback = new DummyTracer();
Expand Down

0 comments on commit b1dc1a3

Please sign in to comment.