Issue #23 - Memory Dump for Large RDB Files #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asasine
reviewed
Apr 19, 2019
| raise Exception('Invalid Command %s' % options.output) | ||
| parser = RdbParser(callback) | ||
| parser.parse(dump_file) | ||
| f = open(options.output, "wb") |
There was a problem hiding this comment.
This file doesn't look like it's being closed after use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to quickly parse large files.
This is just a preview, I will need to cleanup still and test
Steps:
Generate a quick memory dump and index. In quick mode, only compressed_size is valid.
rdb.py -c memory -q --file redis_memory_quick.csv redis.rdb
After viewing, dump a hash/list to view contents of a offending key
rdb.py -c memory --max 1 --pos 3568796958 -v --key mongow --file redis_memory_mongow.csv redis.rdb
Todo:
Cleanup the ziplists sizes
Fix other callbacks (only memorycallback works)
Regression Test