-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common Label in example topologies #98
Comments
good suggestion, I will use |
We should then extend the doc, such that the tag is to be set on setup, since on image import just the specific version tag is available.
|
Yes, that looks good to me. |
my goal is to discontinue the old lab examples as part of that PR.
Which examples you are using from the old selection?
…On Wed, Nov 4, 2020 at 3:16 PM Markus Vahlenkamp ***@***.***> wrote:
Yes, that looks good to me.
We should do the same with the already existing topologies in the
lab-examples folder. Would you please incorporate that as part of your
commit?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLKV5JECPTZQVNCWF4VMPDSOFO2JANCNFSM4TJ25KNA>
.
|
Opportunistically I've been simply utilising the wan-topo. |
but its interesting to see what features of wan-topo I need to replicate Ideally I would like to know if we think about SRL in WAN today, what is the minimum viable topology would be useful to have? I can reuse wan-topo example, but now would be a good time to ask for changes in that topo ADD1: so since the enhancement has been implemented I close this one, we can discuss the wan-topo another time |
I propose using a more general label in the example topologies.
Right now we are using:
I propose to change this to either ´srlinux:latest´... or
srlinux:containerlab
, which would decouple the config from the actual GA release.The text was updated successfully, but these errors were encountered: