Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Label in example topologies #98

Closed
steiler opened this issue Nov 4, 2020 · 7 comments
Closed

Common Label in example topologies #98

steiler opened this issue Nov 4, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@steiler
Copy link
Collaborator

steiler commented Nov 4, 2020

I propose using a more general label in the example topologies.
Right now we are using:

  kind_defaults:
    srl:
      image: srlinux:20.6.1-286

I propose to change this to either ´srlinux:latest´... or srlinux:containerlab, which would decouple the config from the actual GA release.

@steiler steiler added the enhancement New feature or request label Nov 4, 2020
@hellt
Copy link
Member

hellt commented Nov 4, 2020

good suggestion, I will use :latest in the examples I create in #96

@steiler
Copy link
Collaborator Author

steiler commented Nov 4, 2020

We should then extend the doc, such that the tag is to be set on setup, since on image import just the specific version tag is available.

docker tag srlinux:<VERSION-TAG> srlinux:latest

@hellt
Copy link
Member

hellt commented Nov 4, 2020

@steiler I have added the note and fixed the templates in 18b81c8

What do you think?

@steiler
Copy link
Collaborator Author

steiler commented Nov 4, 2020

Yes, that looks good to me.
We should do the same with the already existing topologies in the lab-examples folder. Would you please incorporate that as part of your commit?

@hellt
Copy link
Member

hellt commented Nov 4, 2020 via email

@steiler
Copy link
Collaborator Author

steiler commented Nov 5, 2020

Opportunistically I've been simply utilising the wan-topo.
But I don't have strong feelings about that. Lets get rid of it.

@hellt
Copy link
Member

hellt commented Nov 5, 2020

but its interesting to see what features of wan-topo I need to replicate
I see that wan-topo had some lags between nodes, that was the idea, @henderiw?

Ideally I would like to know if we think about SRL in WAN today, what is the minimum viable topology would be useful to have? I can reuse wan-topo example, but now would be a good time to ask for changes in that topo

ADD1: so since the enhancement has been implemented I close this one, we can discuss the wan-topo another time

@hellt hellt closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants