Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to specify static IP addresses on mgmt net #200

Merged
merged 3 commits into from
Dec 19, 2020
Merged

Conversation

hellt
Copy link
Member

@hellt hellt commented Dec 18, 2020

closes #192

@hellt
Copy link
Member Author

hellt commented Dec 18, 2020

Hi @karimra
do you see any issues with that implementation of static assignment of IP addresses?

@karimra
Copy link
Member

karimra commented Dec 19, 2020

This can fail if a container without a static IP gets assigned an IP that is configured statically under another container.
A few option to go around this:

  • All containers should have a static IP
  • IPs should be automatically added under all containers if at least one container has a configured IP.
  • Schedule containers with a static IP first

@hellt
Copy link
Member Author

hellt commented Dec 19, 2020 via email

@hellt hellt merged commit e1b0929 into master Dec 19, 2020
@hellt hellt deleted the fixed-ips branch January 31, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement static IP assignment for nodes
2 participants