Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer docs #2089

Merged
merged 14 commits into from
Jun 14, 2024
Merged

Devcontainer docs #2089

merged 14 commits into from
Jun 14, 2024

Conversation

hellt
Copy link
Member

@hellt hellt commented Jun 12, 2024

No description provided.

@hellt
Copy link
Member Author

hellt commented Jun 12, 2024

Hi @ankudinov
feel free to give this doc a look. As with any other doc piece in containerlab it is a first iteration of them, will add more as we go.

Just wanted to make sure the initial load is sane enough.

Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to make some changes in the doc as I mentioned in the comments. Especially the private registry part MUST be removed.

docs/manual/codespaces.md Outdated Show resolved Hide resolved
docs/manual/codespaces.md Show resolved Hide resolved
docs/manual/codespaces.md Outdated Show resolved Hide resolved
docs/manual/codespaces.md Outdated Show resolved Hide resolved
docs/manual/codespaces.md Outdated Show resolved Hide resolved
docs/manual/codespaces.md Show resolved Hide resolved
docs/manual/codespaces.md Show resolved Hide resolved
docs/manual/codespaces.md Show resolved Hide resolved
docs/manual/codespaces.md Show resolved Hide resolved
docs/manual/codespaces.md Outdated Show resolved Hide resolved
@hellt hellt marked this pull request as ready for review June 14, 2024 08:39
@hellt
Copy link
Member Author

hellt commented Jun 14, 2024

Thanks for your review @ankudinov

I am merging this now, since I wanted to put up a first edition of this integration, and then it can be iterated over time

@hellt hellt merged commit f2592a6 into main Jun 14, 2024
20 checks passed
@hellt hellt deleted the devcontainer-docs branch June 14, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants