Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg the stage exec struct #2241

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Reorg the stage exec struct #2241

merged 6 commits into from
Oct 22, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Oct 17, 2024

This is a slight reorg to #2238.

The structure is now as follows:

nodes:
    frr1:
      kind: linux
      stages:
        configure:
          exec:
              - command: <command>
                target: <host / container>                optional, with a default of container
                phase: <on-enter / on-exit>            optional, with a default of on-enter

@hellt hellt merged commit f96416d into main Oct 22, 2024
63 of 65 checks passed
@hellt hellt deleted the reorgstageexec branch October 22, 2024 21:13
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 84.93151% with 11 lines in your changes missing coverage. Please review.

Project coverage is 51.74%. Comparing base (6859e39) to head (161cc97).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
clab/dependency_manager/dependency_node.go 79.48% 6 Missing and 2 partials ⚠️
types/stages.go 90.90% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   52.12%   51.74%   -0.38%     
==========================================
  Files         172      172              
  Lines       12714    16699    +3985     
==========================================
+ Hits         6627     8641    +2014     
- Misses       5174     7143    +1969     
- Partials      913      915       +2     
Files with missing lines Coverage Δ
types/topology.go 69.26% <100.00%> (-2.70%) ⬇️
types/stages.go 69.59% <90.90%> (+0.09%) ⬆️
clab/dependency_manager/dependency_node.go 84.21% <79.48%> (-3.45%) ⬇️

... and 160 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants