Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #2224 #2306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for issue #2224 #2306

wants to merge 1 commit into from

Conversation

jkary
Copy link

@jkary jkary commented Nov 19, 2024

This request contains a fix for the GitHub issue 2224. The fix focuses on the separation of labels for multiple links between the same two nodes. There appears to be the following other issues:

  1. Popup labels for a link don't appear in the right place and sometimes shows the wrong link.
  2. Horizontal and vertical layouts appear to have the opposite effect.

As this is my first commit, please help me understand if I am doing something wrong.

Jason

* Updated javascript to display multiple links between nodes in a non-overlapping manner.
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.31%. Comparing base (c06dd25) to head (39794f9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage   51.31%   51.31%           
=======================================
  Files         172      172           
  Lines       16792    16792           
=======================================
  Hits         8617     8617           
  Misses       7253     7253           
  Partials      922      922           
---- 🚨 Try these New Features:

@hellt
Copy link
Member

hellt commented Nov 20, 2024

had a comment about the way it works in our discord: https://discord.com/channels/860500297297821756/1308463195047858217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants