Schedule nodes with static IPs before the ones with dynamic IPs

[karimra]

This PR changes the creation order of nodes by scheduling the ones with static IPs first to avoid dockerd assigning a dynamic IP that is meant for another node (static)

[hellt]

It might be more clear flow-wise to not call createNodes knowing that there is nothing to create beforehand. But that is just my view That will also disable a log message to be printed that would have no meaning in case there are no nodes to schedule Yes, that would apply both to static and dynamic nodes

…

On Fri, 20 Aug 2021 at 14:02, Karim Radhouani ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In clab/clab.go <#592 (comment)>: > + for name, n := range c.Nodes { + if n.Config().MgmtIPv4Address != "" || n.Config().MgmtIPv6Address != "" { + staticIPNodes[name] = n + continue + } + dynIPNodes[name] = n + } + log.Debug("scheduling nodes with static IPs first...") I fail to see the advantage in that change, what if all the nodes are with static IPs and the dynamic nodes are 0? should we do a length for the dynamic IPs as well ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#592 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLKV5MGI3JHUXFSKF6MVI3T5YY5XANCNFSM5COH2MVQ> .

[hellt]

thanks!