Simplify dev setup, by removing pipenv
#115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #67, but massively simplifies.
This is motivated by the issues around pipenv always upgrading every dependency whenever you touch any dependency.
(See pypa/pipenv#2665 and pypa/pipenv#2412)
Removing pipenv means fewer requirements for a development setup, along with a simpler and more-standard process.
I've also removed the YAML linter. There were no YAML files in the repo worth linting, and it's extra dependencies, test setup and confusion which isn't worth it or useful at this stage.
I've also elected not to use
pip-tools
. The dependency chain is very simple, and probably isn't worth the complexity at this point. If we find we need it, it'll be very simple to add back. We're already pinning everything we could reasonably need.