Fix whitespaces #194
Open
Fix whitespaces #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
force-pushed
the
fix-whitespaces
branch
from
c92f04b
to
a61464f
Compare
| @@ -0,0 +1,6 @@ | |||
| [*] | |||
There was a problem hiding this comment.
Suggestion: Should this be validated in CI?
Issue: If editorconfig is going to be expected, it should be called out in the README.
There was a problem hiding this comment.
Maybe? Adding checking in CI is quite a bit more work. The main thing I wanted to sort here was the newlines & autocrlf -- the other bits were things which kinda seemed like a sensible thing to add at the same time.
Happy to add EditorConfig to the README if you think that's useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some minor whitespace issues, plus enable autocrlf and add a
.editorconfigto reduce the chances of them happening again.