Remove pkg_resources dependency #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's deprecated
PeterJCLaw
reviewed
Sep 29, 2024
|
|
||
| def get_db(): | ||
| """Get the parts DB that is embedded with this library.""" | ||
| file = pkg_resources.resource_stream('sr.tools.bom', 'component_lib.csv') | ||
| return Db(six.StringIO(file.read().decode('UTF-8'))) | ||
| file = module_dir / 'component_lib.csv' |
There was a problem hiding this comment.
This creates a dependency on the package being on the filesystem in the same layout as the source, which the previous spelling (I think) did not. Is there no equivalent package resource lookup mechanism in the new world?
(also elsewhere)
There was a problem hiding this comment.
Looks like importlib.resources might be what we want here? Not sure though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves support for Python 3.12.
(CI is very broken, it's not my fault. See #49)