Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI; drop EOL PHP and Symfony versions #127

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add CI; drop EOL PHP and Symfony versions #127

merged 1 commit into from
Dec 18, 2023

Conversation

andrewmy
Copy link
Contributor

  • Add CI which runs existing tests;
  • Do not add EOL PHP and Symfony versions to the build matrix;
  • Drop the EOL versions from composer.json.

@andrewmy
Copy link
Contributor Author

@Nyholm please allow running the workflow here

@andrewmy andrewmy mentioned this pull request Dec 18, 2023
Merged
@Nyholm Nyholm marked this pull request as ready for review December 18, 2023 09:54
Nyholm
Nyholm approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the first CI run, I need to merge it so it can run.

Please follow up issues in a second PR.

@Nyholm Nyholm merged commit 8268c46 into sroze:master Dec 18, 2023
@andrewmy andrewmy deleted the add-ci branch December 18, 2023 09:55
@Nyholm
Copy link
Collaborator

Nyholm commented Dec 18, 2023

Wohoo.

It almost worked.
https://github.com/sroze/messenger-enqueue-transport/actions/runs/7246392911/job/19738239635#step:8:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewmy @Nyholm