Set $apply execution as optional parameter #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelangelmunoz
changed the title
|
I don't think it's a good idea to expose this sort of interface. I think this should always call $apply(). Also IMHOP ngInfiniteScroll is in permanent feature freeze / maintenance mode and people should be using https://material.angularjs.org/latest/demo/virtualRepeat or waiting for angular/components#823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to have an option to manage when angular digest is executed. This is for performance purposes.
In our application we use this library having tons of bindings so a digest flow can take long. Would be nice to have the possibility to execute digest wherever and whenever we want.
We have created a branch adding a new parameter where you can set avoiding the explicit call on $apply().