Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradle 6.0 Deprecations #316

Closed
cdietrich opened this issue Nov 27, 2018 · 6 comments
Closed

Fix Gradle 6.0 Deprecations #316

cdietrich opened this issue Nov 27, 2018 · 6 comments

Comments

@cdietrich
Copy link

When running with Gradle 5.0 i am getting following deprecation warning

> Task :nodeSetup
The IvyArtifactRepository.layout(String, Closure) method has been deprecated. This is scheduled to be removed in Gradle 6.0. Please use the IvyArtifactRepository.patternLayout(Action) method instead.
@deepy deepy mentioned this issue Dec 3, 2018
Open
@cdietrich
Copy link
Author

@deepy am not sure if the can and should be done right know.
patternLayout is still incubating api

@cdietrich cdietrich mentioned this issue Dec 4, 2018
Closed
5 tasks
@deepy
Copy link

deepy commented Dec 14, 2018

I'm strangely enough not getting this warning on https://github.com/node-gradle/gradle-node-plugin, not even with --warning-mode all

@cdietrich
Copy link
Author

cdietrich commented Dec 14, 2018 •
edited
Loading

are you sure you execute nodeSetup actually?

@cdietrich
Copy link
Author

https://github.com/cdietrich/gradle-node-plugin-issue316

@deepy
Copy link

deepy commented Dec 14, 2018 •
edited
Loading

I'm not getting this in my local test repo, which apart from using the old plugin syntax is seemingly identical, strange.
Your test-case works brilliantly though!
It's Friday!
Local gradle was 5.0, wrapper was 4.10.2.

@cdietrich cdietrich mentioned this issue Mar 15, 2019
Closed
cdietrich added a commit to cdietrich/gradle-node-plugin that referenced this issue Jul 8, 2019
@cdietrich
make use of patternLayout instead of layout 'pattern' on gradle 5.0 and
d008401 
later to ensure compatibilty with gradle 6.0

fixes node-gradle#2 respectively
srs/gradle-node-plugin#316

Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@cdietrich cdietrich mentioned this issue Jul 8, 2019
Merged
@deepy deepy mentioned this issue Sep 20, 2019
Open
@cdietrich
Copy link
Author

switched to node-gradle/gradle-node-plugin which has my fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdietrich @deepy