Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with GRADLE_METADATA #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ilmat192
Copy link

@ilmat192 ilmat192 commented Apr 13, 2018

When Gradle 4.6 or higher is used and the GRADLE_METADATA feature is enabled (e.g. by applying the cpp-application plugin), a build fails to resolve the Node distribution as a dependency. This patch fixes this issue using explicitly specified metadata sources.

See details: gradle/gradle#5008

When the GRADLE_METADATA feature is enabled (e.g. by applying
the 'cpp-application' plugin), a build fails to resolve the
Node distribution as a dependency. This patch fixes this issue
using explicitly specified metadata sources.

See details: gradle/gradle#5008
@ilmat192
Copy link
Author

Just noticed that the metadataSources method was introduced only in Gradle 4.5. So if we don't want to drop old versions of Gradle, such a solution will be inappropriate.

But anyway these changes in Gradle's dependency management should be taken into account. Looks like a Node Maven repo mentioned here will be a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant