Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi4 branch #2

Merged
merged 17 commits into from
May 20, 2020
Merged

Pi4 branch #2

merged 17 commits into from
May 20, 2020

Conversation

kbarlee
Copy link
Contributor

@kbarlee kbarlee commented May 12, 2020

Adding a subpage to app notes, providing a stable Pi4 setup guide and config

@CLAassistant
Copy link

CLAassistant commented May 12, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@andrepuschmann andrepuschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tutorial. A few minor things to update but most importantly we need to check why 19.12 works better for you and 20.04.1 doesn't. This shouldn't be the case ;-)

Copy link
Collaborator

@andrepuschmann andrepuschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to reinforce the goal for publishing this app note as soon as we have found/solved the issue you are seeing with the newer releases.

Copy link
Collaborator

@andrepuschmann andrepuschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort on this again. We could reproduce the issue you were having with 20.04 but decided to not fix it straight away in the public release. Therefore, I'd like to ask you to adapt the last bullet point a bit to provide a better explanation to the user. Also, can you please rebase the branch. It seems with the merge of the last appnote there is now a tiny conflict.

@kbarlee
Copy link
Contributor Author

kbarlee commented May 20, 2020

Hey Andre - I think that's everything updated now, with cv2x conflict dealt with too.

@andrepuschmann andrepuschmann merged commit 9d060c2 into srsran:master May 20, 2020
@andrepuschmann
Copy link
Collaborator

Once again, thanks a ton for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants